Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Editing note links throws a graphql error #1591

Closed
maxb2 opened this issue Dec 20, 2021 · 1 comment · Fixed by #1596
Closed

Editing note links throws a graphql error #1591

maxb2 opened this issue Dec 20, 2021 · 1 comment · Fixed by #1596
Labels
Milestone

Comments

@maxb2
Copy link
Member

maxb2 commented Dec 20, 2021

If you are editing the url part of a markdown link, [](here), the terminal starts throwing graphql errors:

Error: Unexpected error value: [{ value: undefined, context: [Array], message: undefined }]
    at locatedError (/workspaces/maxb2/node_modules/graphql/error/locatedError.js:23:78)
    at /workspaces/maxb2/node_modules/graphql/execution/execute.js:479:52
    at async Promise.all (index 0)

Nothing appears to break because of it though.

@maxb2 maxb2 added the bug label Dec 20, 2021
@n1ru4l n1ru4l added this to the v1.17.0 milestone Jan 22, 2022
@n1ru4l
Copy link
Member

n1ru4l commented Jan 22, 2022

The error is caused because it tries to load a note via id that does not yet exist. #1596 should address this as a temporary workaround. The notes loading module needs some refactoring, as this can happen in several places.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants