Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider implementing fastcgi_finish_request()? #62

Closed
withinboredom opened this issue Oct 23, 2022 · 1 comment · Fixed by #69
Closed

Consider implementing fastcgi_finish_request()? #62

withinboredom opened this issue Oct 23, 2022 · 1 comment · Fixed by #69
Labels
enhancement New feature or request

Comments

@withinboredom
Copy link
Collaborator

withinboredom commented Oct 23, 2022

fastcgi_finish_request is often used to perform operations after a request is completed (such as sending an email). Should FrankenPHP implement this and/or create a similar function? There are pro/cons to implementing it with the same name (it will "just work" with existing code), and a con would be that if there are any differences in behavior, then things may not work as expected or code may use the existence of that function as a sentinel that it is running in a fastcgi context and do unexpected things.

I'd be happy to tackle implementing this, whatever is decided.

@dunglas
Copy link
Owner

dunglas commented Oct 23, 2022

Maybe could we add a frankenphp_finish_request() function to prevent any conflict?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants