Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Documentation on not displaying notifications #925

Closed
MithicSpirit opened this issue Sep 28, 2021 · 3 comments
Closed

Documentation on not displaying notifications #925

MithicSpirit opened this issue Sep 28, 2021 · 3 comments

Comments

@MithicSpirit
Copy link

The sample dunstrc states that, to prevent a notification from being displayed, format should be set to "". However, doing so has no effect and creates the output WARNING: Cannot set empty value for setting format. I suspect that this is old behavior that has not been updated in the sample configuration yet.

Installation info

  • Version: v1.6.1-139-ge973cf8
  • Install type: AUR package dunst-git
  • Distro and version: Arch (rolling)
@fwsmit
Copy link
Member

fwsmit commented Oct 3, 2021

Thank you for noticing this. This behaviour has indeed been changed by #803. The right way to skip a notification is skip_display = true. I've updated the dunstrc: e3279c4.

@fwsmit fwsmit closed this as completed Oct 3, 2021
@MaienM
Copy link

MaienM commented Oct 28, 2021

It's great that we have a more intuitive way to skip displaying notifications, but the way the old option was phased out doesn't feel great. This seems to me to be a breaking change made on a minor version change. I would have expected the old way to continue working as well until a major version change, perhaps with a deprecation warning. I can also not find any mention of this change in the changelog (the description of 803 in the changelog certainly doesn't suggest that it will break any existing configs), so I had to dig through the issues to figure out this was an intentional change.

@fwsmit
Copy link
Member

fwsmit commented Oct 28, 2021

Actually this change wasn't intentional. It should be possible again in master. I'll release the next version soon

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants