You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository has been archived by the owner on Oct 6, 2020. It is now read-only.
Developers implementing new BadModuleAttributeUseLinter classes may not realize they have to include both (or more), which opens the door for false negatives. I.e. illegal attributes are being used, but not detected.
False positives can arise in the bar.baz case. E.g.
We should improve detection in BadModuleAttributeUseLinter to account for this. We should also make it work for arbitrary depth imports, e.g. one illegal module attribute definition should catch all of these:
There is currently room for false positives and false negatives in
BadModuleAttributeUseLinter
. Consider the following:Currently, to catch both of these use cases we have to use two illegal module attributes:
This is bad for two reasons:
BadModuleAttributeUseLinter
classes may not realize they have to include both (or more), which opens the door for false negatives. I.e. illegal attributes are being used, but not detected.bar.baz
case. E.g.We should improve detection in
BadModuleAttributeUseLinter
to account for this. We should also make it work for arbitrary depth imports, e.g. one illegal module attribute definition should catch all of these:Instead of requiring multiple:
The text was updated successfully, but these errors were encountered: