Attempt to deflake test_concurrent_lazy_init #51
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It turns out that functools.lru_cache is only mostly thread-safe. It guarantees that the underlying data structure will remain coherent during concurrent updates, but does NOT guarantee that the wrapped function will be called at most once per key. That could lead to calls to new_type unexpectedly returning different types for the same index. Fixes #50.
|
trigger ci |
|
CI failure is #43, which this PR is not aiming to fix. |
biniona
approved these changes
Oct 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It turns out that functools.lru_cache is only mostly thread-safe. It guarantees that the underlying data structure will remain coherent during concurrent updates, but does NOT guarantee that the wrapped function will be called at most once per key. That could lead to calls to new_type unexpectedly returning different types for the same index.
Fixes #50.