iterate params if params value is a list #74
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yizshi
commented
Aug 8, 2023
Comment on lines
357
to
358
| if (params.get(key) instanceof List) { | ||
| List<String> value_list = (List<String>) params.get(key); |
There was a problem hiding this comment.
I am not sure if this is the javaic way (or even if that's the right word) to do this.
ben-duo
requested changes
Aug 8, 2023
|
Close this PR to wait Duo api server side change. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fix #68,
Iterate params all value when the params is a list.
Motivation and Context
There are api endpoints that accept a list. When the request is
GETrequest, we don't have json request body. So we have to make sure the request url has all the value present.How Has This Been Tested?
Tested with example code as well as add unittest
Types of Changes