Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Graceful shutdown #6

Open
elyscape opened this issue Aug 6, 2020 · 2 comments · May be fixed by #15
Open

Graceful shutdown #6

elyscape opened this issue Aug 6, 2020 · 2 comments · May be fixed by #15

Comments

@elyscape
Copy link

elyscape commented Aug 6, 2020

Currently, there doesn't appear to be a way to gracefully shutdown the app. Ideally, it would trap SIGINT and SIGTERM with a handler that finishes sending any already-retrieved log entries to the transport, updates the checkpoints files, and then terminates.
@elyscape
Copy link
Author

elyscape commented Aug 7, 2020

SIGINT appears to be handled in the D194 branch in 2ef41b8. Ideally this would also handle SIGTERM so that this can be run as a service.

elyscape added a commit to elyscape/duo_log_sync that referenced this issue Nov 30, 2020
@elyscape
Gracefully shutdown in response to SIGTERM
4b7169a 
Fixes duosecurity#6
elyscape added a commit to elyscape/duo_log_sync that referenced this issue Nov 30, 2020
@elyscape
Gracefully shutdown in response to SIGTERM
8590003 
Fixes duosecurity#6
@elyscape elyscape linked a pull request Nov 30, 2020 that will close this issue
Open
@elyscape
Copy link
Author

elyscape commented Feb 5, 2021

Any chance of this getting a review? Pinging @rohanbendre @duo-kfleischman.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Gracefully shutdown in response to SIGTERM elyscape/duo_log_sync
1 participant
@elyscape