Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8.8.8.8 DNS Server is hardcoded #259

Open
AaronAtDuo opened this issue Aug 21, 2023 · 1 comment
Open

8.8.8.8 DNS Server is hardcoded #259

AaronAtDuo opened this issue Aug 21, 2023 · 1 comment

Comments

@AaronAtDuo
Copy link
Contributor

Description

In https://github.com/duosecurity/duo_unix/blob/master/lib/util.c#L272 we have the Google DNS server hard-coded
sin.sin_addr.s_addr = inet_addr("8.8.8.8"); /* XXX Google's DNS Server */
Which could be a problem if that's blocked for whatever reason.

As far as I can tell, we aren't actually using/needing DNS here anyway, we just need an IP to create a socket so we can determine the local machine's IP.

Expected Behavior

See if we can avoid needing an external IP at all; if not, maybe make a config option?

Actual Behavior

Access to 8.8.8.8 is necessary for Duo Unix to function.

Steps to Reproduce

N/A

Workarounds

N/A

@kfiresmith
Copy link

Customer here - there are many networks where we block external DNS resolvers. We absolutely detest coming across software that uses such resolvers with no way to change the behavior of.

Just in case you needed some customer sentiment to move this along.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants