Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Alloc error handler removed #192

Closed
HDauven opened this issue Apr 25, 2023 · 0 comments · Fixed by #193
Closed

Alloc error handler removed #192

HDauven opened this issue Apr 25, 2023 · 0 comments · Fixed by #193
Assignees
@HDauven
Labels
fix:bug Something isn't working team:Core Low Level Core Development Team (Rust)

Comments

@HDauven
Copy link
Member

HDauven commented Apr 25, 2023

Describe the bug
In the latest nightly build (rustc 1.71.0-nightly (f5559e338 2023-04-24) the alloc_error_handler attribute has been removed. handle_alloc_error defautls to panic now for no_std environments.

As a result, the CI breaks and divulges from the nightly specified in the repository itself.

To Reproduce
Either install the specified nightly version and run cargo clippy to observe the problem or see the CI result here.

Additional context
Issues pertaining to the recent changes to alloc_error_handler:

We can either opt to lock the CI to the repo version of the nightly Rust version we use, or update the nightly specified in the repo and remove the deprecated allocation error handling for no_std environments.
@HDauven HDauven added fix:bug Something isn't working team:Core Low Level Core Development Team (Rust) labels Apr 25, 2023
@HDauven HDauven mentioned this issue Apr 25, 2023
Merged
@HDauven HDauven self-assigned this Apr 26, 2023
@HDauven HDauven changed the title Alloc error handler removed Removed alloc error handler Apr 26, 2023
@HDauven HDauven changed the title Removed alloc error handler Alloc error handler removed Apr 26, 2023
@ureeves ureeves mentioned this issue Apr 26, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@HDauven HDauven

Labels
fix:bug Something isn't working team:Core Low Level Core Development Team (Rust)
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Support new alloc panic handling dusk-network/piecrust
1 participant
@HDauven