Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

piecrust: improve bootstrap #398

Merged
merged 4 commits into from
Oct 18, 2024
Merged

piecrust: improve bootstrap #398

merged 4 commits into from
Oct 18, 2024

Conversation

herr-seppia
Copy link
Member

Remove merkle.root() calculation during bootstrap

Additionally:

  • Add logs for new vm instantiation
  • remove useless string clone
  • move "calculating root" logs

miloszm
miloszm approved these changes Oct 18, 2024
View reviewed changes
Copy link
Contributor

@miloszm miloszm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks very good to me, nice changes

@miloszm miloszm merged commit b6e993a into full-delta Oct 18, 2024
6 checks passed
@miloszm miloszm deleted the seppia/tests branch October 18, 2024 10:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@miloszm miloszm miloszm approved these changes

@ureeves ureeves Awaiting requested review from ureeves

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@herr-seppia @miloszm