Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove set_trim_size from Circuit #351

Closed
vlopes11 opened this issue Jan 13, 2021 · 0 comments · Fixed by #423
Closed

Remove set_trim_size from Circuit #351

vlopes11 opened this issue Jan 13, 2021 · 0 comments · Fixed by #423
Labels
status:minor Low priority improvements team:Core Low Level Core Development Team (Rust)

Comments

@vlopes11
Copy link
Contributor

This method give the misleading impression to the API consumer that plonk needs to mutate the trim size of a circuit, and that is false.

Even for variable size circuits, the implementor need to provide only a correct get_trim_size to PLONK calculate the correct trim for the public parameters, and this is the only requirement.

Proposal: remove Circuit::set_trim_size

@ZER0 ZER0 added team:Core Low Level Core Development Team (Rust) status:minor Low priority improvements labels Jan 14, 2021
@ZER0 ZER0 closed this as completed Mar 15, 2021
@ZER0 ZER0 reopened this Mar 15, 2021
@ZER0 ZER0 closed this as completed Mar 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status:minor Low priority improvements team:Core Low Level Core Development Team (Rust)
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants