Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hide the serde implementations behind a serde feature #353

Closed
CPerezz opened this issue Jan 13, 2021 · 0 comments
Closed

Hide the serde implementations behind a serde feature #353

CPerezz opened this issue Jan 13, 2021 · 0 comments
Labels
area:cryptography anything related to cryptographic primitives, hashing and ZKP area:serialization-serde Related to De/Serialization of PLONK's data structures status:minor Low priority improvements team:Core Low Level Core Development Team (Rust)

Comments

@CPerezz
Copy link
Contributor

CPerezz commented Jan 13, 2021

We should only need to compile serde when we indeed want to use it. But sometimes this is not necessary, and therefore, we should make it's implementation across the repo gate-featured behind a serde gate.
@CPerezz CPerezz added area:serialization-serde Related to De/Serialization of PLONK's data structures API-design area:cryptography anything related to cryptographic primitives, hashing and ZKP labels Jan 13, 2021
@CPerezz CPerezz added this to the No-std compatibility milestone Jan 13, 2021
@ZER0 ZER0 added team:Core Low Level Core Development Team (Rust) status:minor Low priority improvements labels Jan 14, 2021
@ZER0 ZER0 removed this from the No-std compatibility milestone Jan 18, 2021
This was referenced Mar 5, 2021
Merged
Merged
@ZER0 ZER0 closed this as completed Mar 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area:cryptography anything related to cryptographic primitives, hashing and ZKP area:serialization-serde Related to De/Serialization of PLONK's data structures status:minor Low priority improvements team:Core Low Level Core Development Team (Rust)
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ZER0 @CPerezz