Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow Public Inputs dense repr obtention in pub API #461

Closed
CPerezz opened this issue Mar 12, 2021 · 0 comments
Closed

Allow Public Inputs dense repr obtention in pub API #461

CPerezz opened this issue Mar 12, 2021 · 0 comments
Assignees
@CPerezz
Labels
team:Core Low Level Core Development Team (Rust)

Comments

@CPerezz
Copy link
Contributor

CPerezz commented Mar 12, 2021

Release 0.6 implemented/added StandardComposer::construct_dense_pi_vec as pub(crate) which indeed is where we want to go. The problem is that the libs that only impl complex gadgets but not Circuits, now have to do big refactors and it's quite unconfortable to test them.

Therefore, for now, it has been decided that is better to leave that pub.
@CPerezz CPerezz added area:API team:Core Low Level Core Development Team (Rust) labels Mar 12, 2021
@CPerezz CPerezz self-assigned this Mar 12, 2021
This was referenced Mar 12, 2021
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@CPerezz CPerezz

Labels
team:Core Low Level Core Development Team (Rust)
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@CPerezz