AllocatedScalar refactor #566
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Now instead of mangling with `Variable`s, users will use `AllocatedScalar` instead which includes a reference to the Scalar a `Variable` references. - Make all pub fn's get and return `AllocatedScalar` in their signatures. Now the `Variable` type is something more internal to the crate and there should not be any uses for it outside of the crate internals.
Implements not only all the associated fns needed by `AllocatedScalar` consumers but also all the comodity trait implementations to be able to operate with them on a confy manner.
This includes: - arithmetic - range - logic - boolean - basic conditional selection & other utilities Now all the aformentioned modules and it's exported functions make use of `AllocatedScalar` and ask for it on their signatures to the lib consumers.
LukePearson1
approved these changes
Sep 6, 2021
There was a problem hiding this comment.
This PR LGTM!
I've been through it with @EDGDrummond and it solves the problem of exposing the inner scalar for decomposition gadgets. Feel free to merge.
EDGDrummond
approved these changes
Sep 6, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add
AllocatedScalaras part of PLONK's external APINow instead of mangling with
Variables, users will useAllocatedScalarinstead which includes a reference to theScalar a
Variablereferences.AllocatedScalarin theirsignatures.
Now the
Variabletype is something more internal to the crate andthere should not be any uses for it outside of the crate internals.
This is required in order to be able to externalized some gadgets added into this lib in
modularized_plookupbranch which should have never been included here and need this API change in order to be a thing outside of the lib itself.Resolves: #565