-
Notifications
You must be signed in to change notification settings - Fork 149
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rebase to original Plonk #685
Conversation
Codecov Report
@@ Coverage Diff @@
## master #685 +/- ##
==========================================
- Coverage 82.05% 80.73% -1.32%
==========================================
Files 54 47 -7
Lines 4418 3503 -915
==========================================
- Hits 3625 2828 -797
+ Misses 793 675 -118
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As far as I can tell it LGTM, just one comment that you might want to add but that is up to you
} | ||
|
||
impl Serializable<{ 24 * BlsScalar::SIZE }> for ProofEvaluations { | ||
impl Serializable<{ 16 * BlsScalar::SIZE }> for ProofEvaluations { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You can improve the code-base here by adding a comment that describes the magic number
This PR rebases the code to the original Plonk implementation, but keeping all the recent improvements. It does the following: