Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add and refactor tests for decomposition component #750

Merged
merged 1 commit into from
Mar 30, 2023

Conversation

moCello
Copy link
Member

@moCello moCello commented Mar 22, 2023

Also add a simple example as to how the scalar will be decomposed.

Resolves #738, resolves #704

@codecov
Copy link

codecov bot commented Mar 22, 2023

Codecov Report

Merging #750 (03aa036) into master (8575e27) will increase coverage by 0.10%.
The diff coverage is 93.75%.

❗ Current head 03aa036 differs from pull request most recent head 38aaa09. Consider uploading reports for the commit 38aaa09 to get more accurate results

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #750      +/-   ##
==========================================
+ Coverage   85.23%   85.33%   +0.10%     
==========================================
  Files          54       54              
  Lines        4145     4167      +22     
==========================================
+ Hits         3533     3556      +23     
+ Misses        612      611       -1     
Impacted Files Coverage Δ
tests/decomposition.rs 88.46% <93.18%> (+11.79%) ⬆️
src/composer.rs 91.05% <100.00%> (ø)

... and 1 file with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8575e27...38aaa09. Read the comment docs.

@moCello moCello requested a review from ureeves March 22, 2023 12:05
Also add a simple example as to how the scalar will be decomposed.

Resolves: #738 and #704
@moCello moCello force-pushed the mocello/738_test_decomp branch from d540c75 to 38aaa09 Compare March 22, 2023 12:07
@moCello moCello requested review from xevisalle and ZER0 March 22, 2023 12:28
Copy link
Member

@ureeves ureeves left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@moCello moCello merged commit 0487cc4 into master Mar 30, 2023
@moCello moCello deleted the mocello/738_test_decomp branch March 30, 2023 08:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Refactor and add tests for component_decomposition Document component decomposition with examples
2 participants