Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bugfix-2972 | rusk-wallet: Refactor wallet struct to make impossible states impossible #3091

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

bugfix-2972 | rusk-wallet: Refactor wallet struct to make impossible states impossible #3091

wants to merge 1 commit into from
+643 −262

Conversation

welf
Copy link
Contributor

@welf welf commented Nov 29, 2024 •
edited
Loading

Closes #2972

  • Move version to the file property in Wallet. If we have a valid wallet file, then we know its version.
  • Move the functionalities of wallet path wrapper and wallet file from their implementations to traits (why we need to do it is described here: rusk-wallet: Separate API interfaces from their implementations #3093)
  • Move path validations to the WalletPath creation methods.
  • Add tests for the WalletPath struct creation (WalletPath:new, WalletPath::try_from, and WalletPath::from_str).
  • Add tests for WalletFilePath and SecureWalletFile traits

@welf welf added fix:vulnerability Issues related to fix vulnerabilities of the architecture or software module:rusk-wallet Issues related to rusk wallet labels Nov 29, 2024
@welf welf requested review from Daksh14 and moCello November 29, 2024 12:26
@welf welf force-pushed the bugfix-2972-rusk-wallet-refactor-wallet-struct-to-make-impossible-states-impossible branch from bddee85 to 1bcc58b Compare November 29, 2024 12:35
@welf welf force-pushed the bugfix-2972-rusk-wallet-refactor-wallet-struct-to-make-impossible-states-impossible branch from 1bcc58b to e7c803f Compare November 29, 2024 15:55
@welf welf force-pushed the bugfix-2972-rusk-wallet-refactor-wallet-struct-to-make-impossible-states-impossible branch from e7c803f to d295acf Compare November 29, 2024 16:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Daksh14 Daksh14 Awaiting requested review from Daksh14

@moCello moCello Awaiting requested review from moCello

@Neotamandua Neotamandua Awaiting requested review from Neotamandua

@herr-seppia herr-seppia Awaiting requested review from herr-seppia

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
fix:vulnerability Issues related to fix vulnerabilities of the architecture or software module:rusk-wallet Issues related to rusk wallet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

rusk-wallet: Refactor Wallet struct to make impossible states impossible
3 participants
@welf @herr-seppia @Neotamandua