Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove source_url from data_sources_documents #9953

Open
philipperolet opened this issue Jan 14, 2025 · 1 comment · May be fixed by #10085
Open

Remove source_url from data_sources_documents #9953

philipperolet opened this issue Jan 14, 2025 · 1 comment · May be fixed by #10085
Assignees

Comments

@philipperolet
Copy link
Contributor

philipperolet commented Jan 14, 2025

Depends on #9950

  • compare source_url from documents and nodes to ensure that if document has a source_url, it's the same as node (otherwise, fine)
  • read source_url from nodes, not from documents --- ensure document's source_url isn't used anywhere
  • after a day or 2, drop the column from documents, removing the writes and reads from this column
@philipperolet
Copy link
Contributor Author

Careful to watch for all the times source_url is grabbed from documents --- it should be grabbed from nodes there, e.g. here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants