Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dependency issue with urfave/cli.v1 #256

Closed
tbi88 opened this issue Aug 19, 2019 · 3 comments · Fixed by #261
Closed

Dependency issue with urfave/cli.v1 #256

tbi88 opened this issue Aug 19, 2019 · 3 comments · Fixed by #261

Comments

@tbi88
Copy link

tbi88 commented Aug 19, 2019

I have got the following error while building the docker image.

go: gopkg.in/urfave/cli.v1@v1.21.0: go.mod has non-....v1 module path "github.com/urfave/cli" at revision v1.21.0
go get: error loading module requirements
ERROR: Service 'transfer.sh' failed to build: The command '/bin/sh -c go get -u ./... && CGO_ENABLED=0 GOOS=linux GOARCH=amd64 go build -ldflags -a -tags netgo -ldflags '-w -extldflags "-static"' -o /go/bin/transfersh github.com/dutchcoders/transfer.sh' returned a non-zero code: 1

I solved it by adding the following line at the end of the "go.mod" file.

replace gopkg.in/urfave/cli.v1 => github.com/urfave/cli v1.21.0

@tbi88 tbi88 changed the title Dependency issue with Dependency issue with urfave/cli.v1 Aug 19, 2019
@aspacca
Copy link
Collaborator

aspacca commented Aug 20, 2019

@tbi88 I already opened a ticket on go repo that seems related to the same type of error: golang/go#33154

I experienced that error only on tip, but now I can reproduce yours on go 1.12.7-9 at least.
it seems that some package we use was updated to add gopkg.in/urfave/cli.v1 as dependency: the last build from master was tree year ago and was green (https://travis-ci.org/dutchcoders/transfer.sh/builds/573064818)

do you mind opening a ticket on go? otherwise I will do

@tbi88
Copy link
Author

tbi88 commented Aug 20, 2019

Hi

I would prefer if you could do it. I am pretty new with go yet...

cheers

@aspacca
Copy link
Collaborator

aspacca commented Aug 24, 2019

I switched to use directly github.com/urfave/cli instead of the forked github.com/minio/cli and it's solved

@aspacca aspacca mentioned this issue Aug 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants