Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove react-router #195

Closed
plandem opened this issue Oct 24, 2016 · 12 comments
Closed

remove react-router #195

plandem opened this issue Oct 24, 2016 · 12 comments

Comments

@plandem
Copy link

plandem commented Oct 24, 2016

Do you ever considered to remove react-router? It's bloated library with non-stop breaking changes - already for few years.

Consider at least differ choices, E.g.: https://github.com/callum/redux-routing

p.s.: i'm using this one in our project and quite fine with it.

@sorrycc
Copy link
Member

sorrycc commented Oct 24, 2016

I need to find time to do research. Does it support dynamic load?

@plandem
Copy link
Author

plandem commented Oct 24, 2016

What do you mean "dynamic load"? It's pure redux based (isomorphic) router. No any connection with React. It's up to you how you will connect it with React.

p.s.: you can look for examples for React.

@sorrycc
Copy link
Member

sorrycc commented Oct 24, 2016

@plandem
Copy link
Author

plandem commented Oct 24, 2016

ok, as I said - by default it has no any integration with React, it's up to you how to integrate with React. Finally, you can create something like this HOC component for "dynamic" routes. But this library is lightweight and does only required task - routing. Consider it like low-level routing library.

@plandem
Copy link
Author

plandem commented Oct 24, 2016

https://github.com/callum/redux-routing/blob/master/example/Root.js

It's example how to integrate with React. I don't see any trouble to dynamically "require" component.

@liorix
Copy link

liorix commented Oct 26, 2016

@plandem , @sorrycc -
For what it's worth, I'm not sure I'd go with https://github.com/callum/redux-routing as it doesn't seem like an actively maintained library so I'm not that I'm a big fan of using it as my routing solution...

@plandem
Copy link
Author

plandem commented Oct 26, 2016

@liorix it's stable and what a reason to update stable library? react-router is updating often and still with breaking changes for few years already! So we have:

  1. unstable library with often updates and breaking changes are common
  2. stable library that updates only when bug-fixing.

as for me i would prefer (2).

p.s.: you can always go by other way - take stable "core" library and create own "higher" component around it. It would be much better than take something that can breaks anytime and you have to refresh your knowledge about usage every time.

@soulmachine
Copy link

@plandem how does react-router 4 compare to redux-router ?

@plandem
Copy link
Author

plandem commented Nov 4, 2016

compare by what?! consider it as low-level core library, that can be used to build own router for React. It's just redux router, not react.

@plandem
Copy link
Author

plandem commented Dec 16, 2016

So? If you think it's only me, then you can look here:

I normally try to keep comments here reasoned and civil but the amount of churn in this library is almost so much of a joke that it should become a meme. At this point it's almost more expensive for me to continue updating than it would be to just fork the library and maintain the upgrades myself.
Any time I have to touch react-router I just resign the idea that I'm going to have to take at minimum a day to work out the bugs that pop up with every upgrade, (even minor changes).

Why the huge change? (AGAIN?!)
tl;dr Declarative Composability

The huge change is because the maintainers are apparently unwilling or incapable of either A. Creating something good enough on the first, second, or third attempt, or B. are completely oblivious to the needs of devs trying to create practical software and don't understand that project stability is just as important as a good API.
Thanks but no thanks.

@sorrycc More discussion about next version here:
https://news.ycombinator.com/item?id=12511419

@plandem plandem changed the title remove react-route remove react-router Dec 16, 2016
@plandem
Copy link
Author

plandem commented Dec 16, 2016

here is some another libs to consider (without need to create own HOC for low-level router):
https://github.com/STRML/react-router-component
https://github.com/kriasoft/universal-router

@sorrycc
Copy link
Member

sorrycc commented Jan 22, 2017

Track progress in #530

@sorrycc sorrycc closed this as completed Jan 22, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants