-
Notifications
You must be signed in to change notification settings - Fork 3.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
remove react-router #195
Comments
I need to find time to do research. Does it support dynamic load? |
What do you mean "dynamic load"? It's pure redux based (isomorphic) router. No any connection with React. It's up to you how you will connect it with React. p.s.: you can look for examples for React. |
ok, as I said - by default it has no any integration with React, it's up to you how to integrate with React. Finally, you can create something like this HOC component for "dynamic" routes. But this library is lightweight and does only required task - routing. Consider it like low-level routing library. |
https://github.com/callum/redux-routing/blob/master/example/Root.js It's example how to integrate with React. I don't see any trouble to dynamically "require" component. |
@plandem , @sorrycc - |
@liorix it's stable and what a reason to update stable library? react-router is updating often and still with breaking changes for few years already! So we have:
as for me i would prefer (2). p.s.: you can always go by other way - take stable "core" library and create own "higher" component around it. It would be much better than take something that can breaks anytime and you have to refresh your knowledge about usage every time. |
@plandem how does react-router 4 compare to redux-router ? |
compare by what?! consider it as low-level core library, that can be used to build own router for React. It's just redux router, not react. |
So? If you think it's only me, then you can look here:
@sorrycc More discussion about next version here: |
here is some another libs to consider (without need to create own HOC for low-level router): |
Track progress in #530 |
Do you ever considered to remove react-router? It's bloated library with non-stop breaking changes - already for few years.
Consider at least differ choices, E.g.: https://github.com/callum/redux-routing
p.s.: i'm using this one in our project and quite fine with it.
The text was updated successfully, but these errors were encountered: