Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: cast str to int to satisfy typing on cpms client #282

Merged
merged 1 commit into from
Aug 28, 2024
Merged

fix: cast str to int to satisfy typing on cpms client #282

merged 1 commit into from
Aug 28, 2024

Conversation

fibble
Copy link
Contributor

@fibble fibble commented Aug 28, 2024

Description

cast log level to Ints to work around error in nonprod

Related issue: VOL-5765

Before submitting (or marking as "ready for review")

  • Does the pull request title follow the conventional commit specification?
  • Have you performed a self-review of the code
  • Have you have added tests that prove the fix or feature is effective and working
  • Did you make sure to update any documentation relating to this change?

@fibble fibble requested review from ilindsay and a team as code owners August 28, 2024 15:21
@fibble fibble changed the title fix: Cast str to int to satisfy typing on cpms client fix: cast str to int to satisfy typing on cpms client Aug 28, 2024
JoshuaLicense
JoshuaLicense approved these changes Aug 28, 2024
View reviewed changes
Copy link
Contributor

@JoshuaLicense JoshuaLicense left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ouch 😱 We should really flatten that config, that's deeeeeep! 😄 Looks like it'll fix the current issue though!

@JoshuaLicense JoshuaLicense merged commit 1116488 into main Aug 28, 2024
19 of 20 checks passed
@JoshuaLicense JoshuaLicense deleted the vol-5765-cpms-proxy-500-error branch August 28, 2024 16:08
This was referenced Aug 28, 2024
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JoshuaLicense JoshuaLicense JoshuaLicense approved these changes

@ilindsay ilindsay Awaiting requested review from ilindsay ilindsay is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fibble @JoshuaLicense