fix: cater for some "attached_to" CU fields being null in the DB #337
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fibble
changed the title
fibble
changed the title
jerotire
approved these changes
Sep 18, 2024
ilindsay
approved these changes
Sep 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
attached_tocol onconditions_undertakingsis null by design for some rows. Some places in api we call->getAttachedTo()->getId()style chained methods. Added nullsafe to all the instances i could see callinggetAttachedTo()on in a chain on a conditions undertakings entity.Related issue: VOL-5786
Before submitting (or marking as "ready for review")