Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: removes form__action field from failed postcode lookups #341

Merged
merged 2 commits into from
Sep 20, 2024

Conversation

jerotire
Copy link
Contributor

@jerotire jerotire commented Sep 20, 2024

Description

Removes the .form__action field after failed postcode lookups.

Failing to remove this field causes the form to repeat the same action (postcode lookup or address selection) when the user submits the form. This leads to a server error (500) on failure. By removing the field, users can manually enter their address without hindrance.

Related issue: https://dvsa.atlassian.net/browse/VOL-5807

Before submitting (or marking as "ready for review")

  • Does the pull request title follow the conventional commit specification?
  • Have you performed a self-review of the code
  • Have you have added tests that prove the fix or feature is effective and working
  • Did you make sure to update any documentation relating to this change?

@jerotire jerotire requested review from gabrielg2020 and a team as code owners September 20, 2024 13:40
@ilindsay ilindsay merged commit c1bca49 into main Sep 20, 2024
18 checks passed
@ilindsay ilindsay deleted the fix/VOL-5807 branch September 20, 2024 14:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants