feat: permission fixes, improve permission tests, faciltate check for last op admin user VOL-4718 VOL-5796 #458
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…r last op admin user VOL-4718 VOL-5796
fibble
approved these changes
Nov 19, 2024
gabrielg2020
approved these changes
Nov 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR deals with the selfserve portion of VOL-4718.
Also includes fixes as a result of the permissions reviewed in VOL-5796. Primarily this is preventing transport consultant role being incorrectly given to transport managers. Have also expanded unit tests in this area, in relation to who is and isn't considered an administrator, which was helpful for both tickets.
Related issue: VOL-4718
Related issue: VOL-5796