fix: assets bucket policy #485

Wi11Shell · 2024-11-28T15:24:56Z

Removing role from policy and will be adding in vol-terraform:
components/nonprod/devci/data_aws_iam_policy_document.tf

Before submitting (or marking as "ready for review")

Does the pull request title follow the conventional commit specification?
Have you performed a self-review of the code
Have you have added tests that prove the fix or feature is effective and working
Did you make sure to update any documentation relating to this change?

… once and for all

Wi11Shell and others added 14 commits November 28, 2024 15:24

fix: updated cdn module

e9cdf47

fix: remove original bucket ref

75cdeb7

fix: duplicate ref

11f049d

fix: asset bucket attribute

2ed246d

fix: removed unused ref

e61ec49

fix: asset bucket issue

0f677f6

fix: provider issue

ab98a22

fix: provider issue pt 2

4b40c27

fix: update lock files

cc7d02d

fix: include .gitignore files and remove lock files to resolve issues…

29232db

… once and for all

fix: bucket name using local

d74d78c

docs: update Terraform docs

96038f7

fix: tf-formatting

f0f00ca

fix: remove sts assume role from assets bucket

c445427

Wi11Shell requested a review from a team as a code owner November 28, 2024 15:24

Wi11Shell changed the title ~~Fix: assets bucket policy~~ fix: assets bucket policy Nov 28, 2024

fix: lint - remove unused variable

a581ea4

sdh100shaun approved these changes Nov 28, 2024

View reviewed changes

cmarstondvsa approved these changes Nov 28, 2024

View reviewed changes

Wi11Shell merged commit 9e6a459 into main Nov 28, 2024
19 of 21 checks passed

Wi11Shell deleted the fix-vol-assets-bucket branch November 28, 2024 15:38

github-actions bot mentioned this pull request Nov 28, 2024

chore(main): release 5.10.1 #477

Merged

Wi11Shell restored the fix-vol-assets-bucket branch November 28, 2024 16:20