Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove listbucket perms and tflint #490

Closed
wants to merge 1 commit into from
Closed

Conversation

Wi11Shell
Copy link
Contributor

Remove ListBucket perms as not required for cloud front

Related issue: JIRA_TICKET_NUMBER

Before submitting (or marking as "ready for review")

  • Does the pull request title follow the conventional commit specification?
  • Have you performed a self-review of the code
  • Have you have added tests that prove the fix or feature is effective and working
  • Did you make sure to update any documentation relating to this change?

@Wi11Shell Wi11Shell requested a review from a team as a code owner November 29, 2024 11:03
Copy link
Contributor

Terraform plan for account: nonprod

Commit: 9036dd4

Plan summary

0 to add, 1 to change, 0 to destroy

🔄 Updates

module.account.aws_s3_bucket_policy.bucket_policy

Show full plan
Terraform used the selected providers to generate the following execution
plan. Resource actions are indicated with the following symbols:
  ~ update in-place

Terraform will perform the following actions:

  # module.account.aws_s3_bucket_policy.bucket_policy will be updated in-place
  ~ resource "aws_s3_bucket_policy" "bucket_policy" {
        id     = "054614622558-vol-app-assets"
      ~ policy = jsonencode(
          ~ {
              ~ Statement = [
                  ~ {
                      ~ Action    = [
                          - "s3:ListBucket",
                          - "s3:GetObject",
                        ] -> "s3:GetObject"
                      ~ Resource  = [
                          - "arn:aws:s3:::054614622558-vol-app-assets/*",
                          - "arn:aws:s3:::054614622558-vol-app-assets",
                        ] -> "arn:aws:s3:::054614622558-vol-app-assets/*"
                        # (2 unchanged attributes hidden)
                    },
                ]
                # (1 unchanged attribute hidden)
            }
        )
        # (1 unchanged attribute hidden)
    }

Plan: 0 to add, 1 to change, 0 to destroy.

Copy link
Contributor

Terraform plan for account: prod

Commit: 9036dd4

Plan summary

0 to add, 1 to change, 0 to destroy

🔄 Updates

module.account.aws_s3_bucket_policy.bucket_policy

Show full plan
Terraform used the selected providers to generate the following execution
plan. Resource actions are indicated with the following symbols:
  ~ update in-place

Terraform will perform the following actions:

  # module.account.aws_s3_bucket_policy.bucket_policy will be updated in-place
  ~ resource "aws_s3_bucket_policy" "bucket_policy" {
        id     = "146997448015-vol-app-assets"
      ~ policy = jsonencode(
          ~ {
              ~ Statement = [
                  ~ {
                      ~ Action    = [
                          - "s3:ListBucket",
                          - "s3:GetObject",
                        ] -> "s3:GetObject"
                      ~ Resource  = [
                          - "arn:aws:s3:::146997448015-vol-app-assets/*",
                          - "arn:aws:s3:::146997448015-vol-app-assets",
                        ] -> "arn:aws:s3:::146997448015-vol-app-assets/*"
                        # (2 unchanged attributes hidden)
                    },
                ]
                # (1 unchanged attribute hidden)
            }
        )
        # (1 unchanged attribute hidden)
    }

Plan: 0 to add, 1 to change, 0 to destroy.

@Wi11Shell Wi11Shell closed this Nov 29, 2024
@Wi11Shell Wi11Shell deleted the fix-tflint-errors branch November 29, 2024 11:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant