Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add execution order number (avoid order conflict with vrik) #124

Merged
merged 2 commits into from
Jan 18, 2019
Merged

add execution order number (avoid order conflict with vrik) #124

merged 2 commits into from
Jan 18, 2019

Conversation

neon-izm
Copy link
Contributor

VRIKやFinalIKとUniVRMを併用するときに、使用者が意識せずともVRMSpringBoneの処理がIK計算の後に行われるようにしておくと、ハマりが減って良いと思います。
現在のアセットストアで入手可能なVRIKおよびFinalIKは <11000のScriptExecutionOrderになっています。

Copy link
Contributor

@yutopp yutopp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PRありがとうございます!LGTMです。
2checksでマージしたいと考えています。 @ousttrue

@yutopp yutopp requested a review from ousttrue January 17, 2019 12:12
@yutopp yutopp added this to the v0.49 milestone Jan 17, 2019
Copy link
Contributor

@ousttrue ousttrue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yutopp yutopp merged commit 5a23d64 into vrm-c:master Jan 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants