Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Always SkinnedMeshRenderer.updateWhenOffscreen is true for SkinnedMes… #135

Merged
merged 1 commit into from
Jan 23, 2019
Merged

Always SkinnedMeshRenderer.updateWhenOffscreen is true for SkinnedMes… #135

merged 1 commit into from
Jan 23, 2019
+1 −0

Conversation

ousttrue
Copy link
Contributor

Headless model that created by VRMFirstPerson should updateWhenOffscreen = true.

  • It is not good that avatar's body is culled incorrectly
  • At most, there is only one

yutopp
yutopp approved these changes Jan 23, 2019
View reviewed changes
Copy link
Contributor

@yutopp yutopp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🙏 I always set that manually....

@yutopp
Copy link
Contributor

yutopp commented Jan 23, 2019 •
edited
Loading

Would the issue #133 be resolved by this PR?

@yutopp yutopp added this to the v0.49 milestone Jan 23, 2019
@ousttrue ousttrue merged commit 0205b86 into master Jan 23, 2019
@ousttrue ousttrue deleted the updateWhenOffscreen_for_firstPerson branch January 23, 2019 16:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yutopp yutopp yutopp approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v0.49
Development

Successfully merging this pull request may close these issues.
2 participants
@ousttrue @yutopp