Tasklet update #4
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Starts tasklets when they're co_awaited upon or get() is called.
Needed to make promise_type_base destructor virtual
Otherwise you get a destroy-when-locked on Windows, which sensibly terminates.
And also ensure that get() throws if the coroutine isn't yet complete.
And rename the basic exception rethrowing.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The latter is important for exception handling sanity - it means the caller always gets the result value via the promise_type::get() - ultimately at least - and this means that we can rethrow exceptions here.
Also, the completion signal is emitted during the final_suspend which seems more correct (and this may happen during either an exception or at normal completion).