Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Untagged dynamic version should not be considered as newer than tagged versions #99

Closed
Atry opened this issue Apr 19, 2019 · 0 comments
Closed

Untagged dynamic version should not be considered as newer than tagged versions #99

Atry opened this issue Apr 19, 2019 · 0 comments

Comments

@Atry
Copy link
Contributor

Atry commented Apr 19, 2019 •
edited
Loading

Currently we have the following generated versions:

Case version isSnapshot isVersionStable
when on tag v1.0.0, w/o local changes 1.0.0 false true
when there are no tags, on commit 1234abcd, w/o local changes 3-1234abcd true true

3-1234abcd is a horrible version because most of build tools consider it newer than 1.0.0, therefore module ID like "xxx" %% "xxx" % "1+" or "xxx" %% "xxx" % "latest.version" will be resolved to 3-1234abcd.

We should generate some versions like 0+3-1234abcd instead of 3-1234abcd.
Atry added a commit to Atry/sbt-dynver that referenced this issue Apr 19, 2019
@Atry
Untagged dyn version should not be considered as newer than tagged ve…
819acff 
…rsions (fix sbt#99)
@Atry Atry changed the title Untagged dyn version should not be considered as newer than tagged versions Untagged dynamic version should not be considered as newer than tagged versions Apr 19, 2019
Atry added a commit to Atry/sbt-dynver that referenced this issue Apr 22, 2019
@Atry
An untagged dynamic version should not be considered as newer than ta…
1d8fd42 
…gged versions (fix sbt#99)
dwijnand added a commit that referenced this issue May 6, 2019
@dwijnand
Untagged dynamic version should not be considered as newer than tagge…
f9a4262 
…d versions (fix #99) (#100)

Untagged dynamic version should not be considered as newer than tagged versions (fix #99)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@Atry