-
-
Notifications
You must be signed in to change notification settings - Fork 58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support new 'adaptive' icons in Android 8+ #60
Comments
I think it would be great to support this, thanks for sharing! I'll take a look at it when I get a little time, probably a couple of weeks from now :) |
@dwmkerr what's the status of this issue? Is it expected to be done soon? |
Hi @the-rs it'll be a couple of weeks still before I can look at this, but will be using it for a project I'm working on then so will definitely be getting onto it1 |
Hey @dwmkerr . Just looking for an update on this issue? |
I got the Windows build and tests working which slowed me down, I can actually and finally look at this now. One thing I'd love is a suggestion on how we manage the multiple images - should it be something like a convention to have:
Or command line flags? At the moment, here are my design goals:
Does anyone else have any suggestions? |
Hi @dwmkerr ! As for the design goals, they seem pretty comprehensive to me. Again, thanks a lot for your efforts. They're much appreciated. |
Hello @dwmkerr ! |
Yep will be pushing it in shortly! |
@dwmkerr hello, what's the status? |
@dwmkerr any update on this? |
OK for those watching the issue, here's the progress. I'll keep the updates on this comment:
Current Issues
|
OK! Finally 😄 This took a lot longer than expected to get right, and I am still not 100% sure it is perfect, but adaptive icon support is available in v0.11.0 In short, first create some template icons: $ app-icon init --adaptive-icons
icon.png created
icon.background.png created
icon.foreground.png created This will create the icons you can use as your main template icons. Then spit out each size with: $ app-icon generate --adaptive-icons At the moment, all adaptive icon features are 'opt-in' with the |
Android 8+ has a set of new guidelines for app icons: https://developer.android.com/guide/practices/ui_guidelines/icon_design_adaptive
The general idea is that you provide an icon and a background colour. The icon has transparency, and is overlaid onto the background colour. The whole thing is then masked by the device, to produce a circle, square, rounded square, etc. To facilitate a circular mask, you can also specify a different icon to use for circular masks.
I'm adding this issue more as a 'nice to have', as it would require a few changes for sure! Some way of asking:
and then the associated changes to the XML files as described in the above link.
Unfortunately I don't have any spare time to dedicate to a PR right now, but thought I'd bring it up in case it was on your roadmap.
Thanks for a great library - it's been a big timesaver for me 😄
The text was updated successfully, but these errors were encountered: