Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Completed tasks #26

Merged
merged 8 commits into from
May 26, 2021
Merged

Completed tasks #26

merged 8 commits into from
May 26, 2021

Conversation

SimonLab
Copy link
Member

ref: #25

@SimonLab SimonLab self-assigned this Feb 12, 2021
@codecov
Copy link

codecov bot commented Feb 12, 2021

Codecov Report

Merging #26 (6344af7) into master (288d0ff) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##            master       #26   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            5         6    +1     
  Lines           62        84   +22     
=========================================
+ Hits            62        84   +22     
Impacted Files Coverage Δ
lib/models/todoList.dart 100.00% <100.00%> (ø)
lib/screens/completed_tasks/completed_tasks.dart 100.00% <100.00%> (ø)
lib/screens/tasks/tasks.dart 100.00% <100.00%> (ø)
lib/screens/tasks/todolist.dart 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 288d0ff...6344af7. Read the comment docs.

@nelsonic
Copy link
Member

@SimonLab this is looking good so far. 😍
Please assign when you feel it's ready for review/merge. 👍
Thanks. 🌻

@SimonLab
Copy link
Member Author

SimonLab commented May 26, 2021

I've updated the branch with the code from the master branch and tested that everything is working correctly.
I think this PR is ready for review @nelsonic
Next I'll update the code to add Riverpod, see #27

@SimonLab SimonLab marked this pull request as ready for review May 26, 2021 11:48
@nelsonic nelsonic self-requested a review May 26, 2021 12:21
Copy link
Member

@nelsonic nelsonic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@SimonLab looks great. 🎉

@nelsonic nelsonic merged commit deca900 into master May 26, 2021
@nelsonic nelsonic deleted the completed-tasks-#25 branch May 26, 2021 13:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants