Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove people table from database on Fly.io #285

Closed
2 tasks done
SimonLab opened this issue Jan 25, 2023 · 3 comments
Closed
2 tasks done

Remove people table from database on Fly.io #285

SimonLab opened this issue Jan 25, 2023 · 3 comments
Assignees
@nelsonic @LuchoTurtle
Labels
please-test Please test the feature in Staging Environment and confirm it's working as expected.

Comments

@SimonLab
Copy link
Member

SimonLab commented Jan 25, 2023 •
edited
Loading

#281 has been fixed by removing the foreign key items_people_id.
However the people table still exists on the database.

  • Check all the foreign keys are removed
  • Drop the people table
@SimonLab SimonLab added the in-progress An issue or pull request that is being worked on by the assigned person label Jan 25, 2023
@SimonLab SimonLab self-assigned this Jan 25, 2023
@SimonLab SimonLab moved this to 🏗 In progress in dwyl app kanban Jan 25, 2023
@SimonLab
Copy link
Member Author

The tags table still has a foreign key index to the people table:
image

Running: alter table tags drop constraint tags_person_id_fkey; to remove the index. We should now be able to drop the people table with drop table people;

Listing the tables:
image

@nelsonic @LuchoTurtle let me know if you have any issues with the mvp but I think now the database reflect the migrations files we have on the project.

@SimonLab SimonLab moved this from 🏗 In progress to ✅ Done in dwyl app kanban Jan 25, 2023
@SimonLab SimonLab added please-test Please test the feature in Staging Environment and confirm it's working as expected. and removed in-progress An issue or pull request that is being worked on by the assigned person labels Jan 25, 2023
@SimonLab SimonLab assigned nelsonic and LuchoTurtle and unassigned SimonLab Jan 25, 2023
@nelsonic
Copy link
Member

@SimonLab go for it. thanks. 👍

@SimonLab
Copy link
Member Author

No errors reported closing for now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nelsonic nelsonic

@LuchoTurtle LuchoTurtle

Labels
please-test Please test the feature in Staging Environment and confirm it's working as expected.
Projects
dwyl app kanban
Status: ✅ Done
Milestone
No milestone
Development

No branches or pull requests
3 participants
@nelsonic @SimonLab @LuchoTurtle