Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Post Incident Practices module #87

Merged
merged 2 commits into from
Dec 16, 2020

Conversation

tom-halpin
Copy link
Contributor

Proposed changes

Added Post Incident Practices module

Types of changes

What types of changes does your code introduce to Online DevOps Dojo?
Put an x in the boxes that apply

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Code style update (formatting, renaming)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Workflow change
  • Documentation update (if none of the other choices apply)

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

  • I have read the CONTRIBUTING doc.
  • Lint passes locally with my changes.
  • I have added necessary documentation (if appropriate).
  • Any dependent changes have been merged and published in downstream modules

Further comments

If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc...

@tom-halpin tom-halpin requested a review from a team as a code owner December 16, 2020 09:33
@tom-halpin
Copy link
Contributor Author

@cpswan @ojacques @pberthonneau open sourcing Post Incident Practices module by way of a small thank you to the community given the very positive reaction to the Dojo since we launched it.

Copy link
Contributor

@adamdmharvey adamdmharvey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Two minor points from my side but I can see this being super valuable in the community!

CHANGELOG.md Outdated Show resolved Hide resolved
online-devops-dojo/welcome/intro.md Show resolved Hide resolved
@tom-halpin tom-halpin merged commit 06f583c into dxc-technology:master Dec 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants