Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support one click unsubscribe #168

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Support one click unsubscribe #168

wants to merge 1 commit into from

Conversation

asmega
Copy link

@asmega asmega commented Dec 3, 2024 •
edited
Loading

Context

  • Support one_click_unsubscribe_url used by official notify client

Changes

  • one_click_unsubscribe_url can now be passed to mailer which forwards onto official notify client
  • Modified some tests which were duplicated across multiple blocks
  • Updated README to document the new feature

Review notes

  • I've tested this locally with scoped notify key and it addded the following headers (obfuscated)
List-Unsubscribe: <https://localhost:3000/some/end/point?opaque=123>
List-Unsubscribe-Post: List-Unsubscribe=One-Click
  • Unfortunately the email client I have access to is either pants, doesn't support it or I can't figure out how to turn it on so couldn't do full end to end

@asmega asmega force-pushed the one-click-unsubscribe branch from 270ba89 to bc8c25a Compare December 3, 2024 12:50
@asmega asmega mentioned this pull request Dec 3, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@asmega