Plugin doesn't work when entering power station id #10
Comments
|
solution added to PR #9 |
Forgot to log. Sorry. When disabling the station ID this is the error log. Only one inverter shows up.
|
|
Hi @dentinox , From the log it is not clear:
|
|
Started fresh again. See log. And yes. I have done a git pull : ). Restart the services. Nothing. Powered down the pi. Still not showing up to date version. 2020-03-17 22:14:17.622 Status: Domoticz V4.10717 (c)2012-2019 GizMoCuz |
|
Hi @dentinox , 2 things: Secondly, from the line numbers of the errors I also see you do not have the latest version. Please check the following: This should return oa: to be 100% sure, you pull using: likely some Git thing. I'm not really a Git expert...... |
|
pi@raspberrypi:~/domoticz/plugins/domoticz-GoodWeSEMS $ git status Changes not staged for commit: no changes added to commit (use "git add" and/or "git commit -a") Is this right? |
|
Again, I'm no Git expert, but: did you use? |
|
yes. Freshly installed raspian buster lite. Same issue. I then reinstalled everything again. But then the plugin didn't show up in the hardware list. After installing pp-manager I can see it. That is the set up I am running now. Also : I tried to git pull dylian94 and JanjaapKo on freshly installed SD's. Same issue. |
|
Hi, Installing the plugin via the PP-manager I never tried. Can not guarantee that that will work. How I did it, on clean system: I do not know what the pp-manager does so if you can try again without that? |
|
Did a complete new install
GoodWeSEMS not appearing in Hardware
GoodWeSEMS appears in hardware. But no devices Status |
|
Hi @dentinox , At first glance everything you do seems perfect. But still you are stuck on version 1.2.1 of the plugin which is causing this issue. onMessage is calling stationDataRequest without a valid ID, that part I fixed in 1.2.3...... 1 question: before making the fresh install, did you format your SD card? If not, the old information will still be present. The only thing I can see so far is that you should update Domoticz to beta:
And I'm running Python 3.7.3 but that shouldn't matter |
|
I have tested it on another PI (3). Brand new SD. Exactly the same error message. Here is the update log. |
|
I fixed it. I had to merge the last changes via a PR on my own fork.... Works like a charm now. On a clean install you can do: for an exisiting install On a previously pulled 1.2.1 version I now get 1.2.3......... You're right, it does have something to do with GIT. I tried the same thing in \tmp ad I also get 1.2.1 as plugin version. Really strange: when I use Git desktop to pull the version that is in the PR addException, I doe get version 1.2.3 in Windows........Please find attached my version (although GIT's idea is to prevent manual file sharing ;) ) I had to rename them to .txt..... I'll try to figure out what I'm doing wrong with GIt. In the mean whie, please see what happens with this version and your multiple inverters. Given this whole corona situation, it is nice to have a hobby like this ;) |
|
That's it. Running 1.2.3 now. It finds the complete families inverters. I cut these out of the log due all of the address information. 2020-03-21 16:10:46.982 (Zonnepanelen) inverter created: 'Inverter type: 'Huis 12x' with serial number: '93000SSN17BW1990'' |
|
That's good news! Was this log created with debug logging? I need the input from the API data to fix this. I'll have a look tonight if you can send the logs. Regards |
|
debug log domoticz.txt 2020-03-21 16:37:54.527 Status: Domoticz V4.11799 (c)2012-2020 GizMoCuz |
|
Hi, I looked at your logging and it seems quite fine (apart from the error of coarse...) Some things I find strange:
Anyhow, I did some modifications, please pull new version and let me know. |
|
I removed 12 members of the portal from the log. My serials are the four shown (afdak/sauna/loods/huis) 2020-03-22 21:34:49.447 (Zonnepanelen) inverter created: 'Inverter type: 'Huis 12x' with serial number: '93000SSN17BW1990'' new errors 2020-03-22 21:33:14.634 Status: (Zonnepanelen) Initialized version 1.2.4, author 'dylian94' |
|
I narrowed the issue down to users with multiple inverters. If I enter the station ID of my dad (2 inverters) I get the following error 2020-03-23 07:31:26.406 Error: (Zonnepanelen) 'onMessage' failed 'TypeError':'can only concatenate str (not "NoneType") to str'. If I select my brother with 1 inverter it works fine. I can select the devices and everything shows up. |
|
Hi, Please add complete loggings. I mis too many lines now to do something with it. You can also switch on logging to file which may be easier to capture everything:
|
|
I noticed that when I create a Goodwe Guest account for my 4 inverters only it works without issues. Do you still want the log to fix it for the global account issues? |
|
Hi, Apparently you have an interesting account structure, so yes ;) Can you also add a description of how your account is setup? Since I only have 1 single inverter in my house (powerstation) and 1 house in my account..... |
|
I have 12 family member on my portal. All have 1 inverter. I have 4. When I add my station ID you get the error we are talking about. I'll give you a log with my station ID and one with all stations. Keep in mind that it takes some time as I need to remove all address information : ) |
|
Hi @dentinox I did some modifications and I 'd really like to know if they work for multiple inverters. Please pull using: |
|
Although I'm just having a single inverter (2 MPPT) I tried this code because the normal release did not work for me. I got same result, so decided to do some debugging and found an issue. The line Domoticz.Debug("inverter created: '" + str(self.inverters[inverter['sn']]) + "'") in GoodWe.py causes a python (3.7.3) error for me. |
|
Hi @CodingEJ , Thanks for trying the plugin. Strange that this leads to an error for 2 reasons:
Can you run the plugin in debug mode so I can get the logging? I need:
|
|
Hi JanJaapKo, It's not so much related to the API data, it's a python error where it does not know how to print the serial number. By replacing the construct by the simpler one you get your desired result and it works. Error detail: |
|
@dentinox Is the plugin now working (when you pull latest version from my fork)? If not please add a logfille with all the loglines as I need the API data from GoodWe so I can run some test by entering this info manually. |
Describe the bug
When entering the optional power station ID in the Plugin config an error occurs:
2020-03-15 20:53:37.559 Error: (Zonnepanelen) 'onMessage' failed 'AttributeError':''str' object has no attribute 'id''. 2020-03-15 20:53:37.559 Error: (Zonnepanelen) ----> Line 368 in '/home/pi/domoticz/plugins/domoticz-GoodWeSEMS/plugin.py', function onMessage 2020-03-15 20:53:37.559 Error: (Zonnepanelen) ----> Line 192 in '/home/pi/domoticz/plugins/domoticz-GoodWeSEMS/plugin.py', function onMessage 2020-03-15 20:53:37.559 Error: (Zonnepanelen) ----> Line 287 in '/home/pi/domoticz/plugins/domoticz-GoodWeSEMS/GoodWe.py', function stationDataRequestTo Reproduce
Steps to reproduce the behavior:
add optional powerstation id and update plugin
Expected behavior
no error
Screenshots
If applicable, add screenshots to help explain your problem.
Domoticz environment (please complete the following information):
The text was updated successfully, but these errors were encountered: