Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tomb close tc.tomb doesn't close tc.tomb #321

Open
stevelitt opened this issue Sep 30, 2018 · 10 comments
Open

tomb close tc.tomb doesn't close tc.tomb #321

stevelitt opened this issue Sep 30, 2018 · 10 comments
Assignees
Labels
discussion enhancement An issue to improve current behavior
Milestone

Comments

@stevelitt
Copy link

What am I doing wrong?

tomb close tc.tomb

tomb [E] There is no open tomb to be closed.

( Then I successfully opened tc.tomb onto /media/tc )

tomb close -k tc.tomb.key tc.tomb

tomb [E] There is no open tomb to be closed.

ls /dev/mapper

control tomb.tc.1538336392.loop0 tomb.tc.1538337069.loop1

mount | grep loop

/dev/mapper/tomb.tc.1538336392.loop0 on /media/tc type ext4 (rw,nodev,noatime)
/dev/mapper/tomb.tc.1538337069.loop1 on /media/tc type ext4 (rw,nodev,noatime)

OTHER INFO...
Void Linux, up to date as of this morning.

[root@mydesk ~]# uname -a
Linux mydesk 4.18.11_1 #1 SMP PREEMPT Sat Sep 29 11:55:22 UTC 2018 x86_64 GNU/Linux
[root@mydesk ~]#

Sudo version 1.8.25p1
cryptsetup 2.0.4
pinentry-curses (pinentry) 1.1.0
Copyright (C) 2016 g10 Code GmbH
License GPLv2+: GNU GPL version 2 or later https://www.gnu.org/licenses/
This is free software: you are free to change and redistribute it.
There is NO WARRANTY, to the extent permitted by law.
findmnt from util-linux 2.32.1
gpg (GnuPG) 1.4.23 - key forging algorithms (GnuPG symmetric ciphers):
/usr/bin/gpg
IDEA 3DES CAST5 BLOWFISH AES AES192 AES256 TWOFISH CAMELLIA128 CAMELLIA192 CAMELLIA256

@roddhjav
Copy link
Contributor

Hi, can you try with the following command and provide us with its output:

tomb -D close tc

@stevelitt
Copy link
Author

https://pastebin.com/iNUYMnnN

[root@mydesk dovecot]# cat tombclose.txt
tomb [D] Identified caller: root (0:0)
tomb [D] Tomb command: close tc.tomb
tomb [D] Caller: uid[0], gid[0], tty[/dev/pts/4].
tomb [D] Temporary directory: /tmp/zsh
tomb [E] There is no open tomb to be closed.
[root@mydesk dovecot]#

And then...

[root@mydesk dovecot]# ls -ldF /tmp/zsh
drwxrwxrwt 2 root root 40 Sep 30 15:51 /tmp/zsh/
[root@mydesk dovecot]#

@roddhjav
Copy link
Contributor

Ok, it's because tomb close takes as argument the tomb name (tc) and not the tomb path (tc.tomb). So simply do tomb close tc and it should work.

Alternatively, you can also do tomb close or tomb close all to close all the opened tomb. You can also use tomb list to list the opened tomb.

@jaromil
Copy link
Member

jaromil commented Oct 1, 2018

hi Steve! indeed that should be it. Lets add support for this corner case however, close could detect and strip the .tomb extension passed on command line.

@stevelitt
Copy link
Author

Where can I find a tomb mailing list or even better a tomb IRC channel?

@stevelitt
Copy link
Author

Thanks for the info. I never would have thought of just using "tc". Thanks!

@jaromil
Copy link
Member

jaromil commented Oct 1, 2018

There was a list once used, but not anymore (silent since years) for all things crypto at dyne that is https://mailinglists.dyne.org/cgi-bin/mailman/listinfo/crypto
best is anyway IRC channel #dyne on our server irc.dyne.org

@stevelitt
Copy link
Author

Thank you for the tomb close -D, tomb close, tomb close tc (in my example) and the tomb list commands. I managed to close the thing with tomb slam (it had said something was still using it). However, there's still left over /dev/mapper/tomb.tc.1538337069.loop1 (the loop 0 one was closed by the tomb commands). How do I get rid of that mapper file? losetup -d /dev/loop1 didn't do it.

Thanks!

@jaromil
Copy link
Member

jaromil commented Oct 2, 2018

Ack, slam sometimes fails on that. Mapper volumes should be closed by cryptsetup luksClose but when the loopback is missing underneath they may be left hanging.

@jaromil
Copy link
Member

jaromil commented Sep 8, 2024

Revisiting this, we should support also full filename (with .tomb extension) in close and slam commands, as it is rather intuitive and has path completion. This can be supported both on relative and absolute paths: argument to full file path.

@jaromil jaromil added the enhancement An issue to improve current behavior label Sep 8, 2024
@jaromil jaromil self-assigned this Sep 8, 2024
@jaromil jaromil added this to the 3.0 milestone Sep 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
discussion enhancement An issue to improve current behavior
Projects
None yet
Development

No branches or pull requests

3 participants