Add support for sudo alternatives (e.g. doas) #412
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
heat-wave
commented
Apr 7, 2021
heat-wave
commented
- Replaced a stray unwrapped sudo usage with _sudo call
- doas does not support custom prompts, so the formatted message still only applies to sudo
- Not entirely sure how many tests we want to cover that functionality with; I added basic ones but can duplicate others (with the same --sudo doas) as well
Closed
Narrat
reviewed
Apr 7, 2021
| | gpg --batch --passphrase-fd 0 --no-tty --no-options -d $tomb_key \ | ||
| | hexdump -C && | ||
| tt_lock --tomb-pwd $DUMMYPASS --sphx-user $DUMMYUSER --sphx-host $DUMMYHOST | ||
| ' |
There was a problem hiding this comment.
Also wrong indention. Seems that this should be a real tab.
Edit: Ignore that. I only looked at the first commit at that time
jaromil
requested changes
Apr 8, 2021
jaromil
approved these changes
Apr 15, 2021
|
Many thanks for this contribution!! |
|
as this is now merged ill close the doas support issue #410 great work guys, thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.