Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feature request]: Use default key mapping for Quickfix mode #157

Closed
skamsie opened this issue Feb 14, 2017 · 6 comments
Closed

[feature request]: Use default key mapping for Quickfix mode #157

skamsie opened this issue Feb 14, 2017 · 6 comments

Comments

@skamsie
Copy link

skamsie commented Feb 14, 2017

First of all great plugin. I did not find any problems I just want to make a suggestion.

I use the Quickfix mode more often and it seems that there is only one way of opening the files in that mode, using (Enter). I would like to be able to use the normal keys like in the CtrlSF window:

p - Like Enter but open file in a preview window.
P - Like Enter but open file in a preview window and switch focus to it.
O - Like Enter but always leave CtrlSF window opening.
T - Like t but focus CtrlSF window instead of new opened tab.

Thanks

@dyng
Copy link
Owner

dyng commented Feb 15, 2017

Thanks for your good suggestion. First of all, I will explain why I have added :CtrlSFQuickfix command, quote from another related issue #154 .

...I'm curious about why you favor :CtrlSFQuickfix over :CtrlSF? I have added quickfix-serial commands because of a user request, but not so satisfied with it myself. Mostly because of its limited feature, inconsistent interface and I almost never have used it.

But so many users love CtrlSFQuickfix, I think there are some reasons that I don't know. Here are some possible reasons that I thought

  • more compact view of results
  • builtin commands for quickfix window
  • plugins that enhance quickfix window
  • a similar user experience of ack.vim

Can you tell me your points why you favor CtrlSFQuickfix over CtrlSF? I'll consider to provide a more useful, fully featured CtrlSFQuickfix alternative.

@skamsie
Copy link
Author

skamsie commented Feb 15, 2017

Well to be completely honest someone introduced me to ack.vim, which only displays to quickfix. The biggest problem with ack, which stops me from using it is this bug: mileszs/ack.vim#18 which I don't think is getting fixed soon...

That is how I searched for alternatives and stumbled upon your plugin, which again I think it is great, but for me personally, the "Sublime like" view offers too much context which I don't really need...

@dyng
Copy link
Owner

dyng commented Feb 16, 2017

If there is a command that you can switch result window between 'compact' view and 'normal' view, does that suffice your needs? (also an option lets you use compact view by default)

@skamsie
Copy link
Author

skamsie commented Feb 16, 2017

I would like to be able to open a file in a preview window without the cursor jumping to it by pressing p, when using :CtrlSFQuickfix. That's all :)

@dyng
Copy link
Owner

dyng commented Feb 16, 2017

Well, 'compact' ctrlsf window (not a quickfix window) will have all features of ctrlsf, including p for file preview.

But it will not be coming soon, so please be patient for it. If you only want to reduce contexts, you can invoke ctrlsf by :CtrlSF -C 0 foobar as a workaround.

@dyng
Copy link
Owner

dyng commented Feb 25, 2017

Close this issue as #159 is merged.

@dyng dyng closed this as completed Feb 25, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants