Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Slingshot native results vs dyn #161

Open
royfrancis opened this issue Nov 30, 2019 · 2 comments
Open

Slingshot native results vs dyn #161

royfrancis opened this issue Nov 30, 2019 · 2 comments

Comments

@royfrancis
Copy link

Here is slingshot result run manually.
traj-temp-2

Here is slingshot run using dyn on the same data.
traj-temp-1

I think they look different and I am not sure what to make of it. Any thoughts?

@rcannood
Copy link
Member

This is because a previous version (or maybe still the master version of dyno?) did not return the segment positioning of Slingshot, only the way that milestones are connected. What you are seeing is a projecton of the Slingshot trajectory onto the provided dimred.

Which version of dynmethods and dynplot are you using?

@rcannood
Copy link
Member

rcannood commented Nov 30, 2019

Update: nevermind, not even the current version is returning this info (https://github.com/dynverse/ti_slingshot/blob/master/package/R/ti_slingshot.R#L193). I'll fix this asap.

However, please note that this only affects the plot_dimred visualisation ; other downstream analyses of the trajectory are unaffected by this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants