Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CloudForCustomers - remove get_response() method #1081

Open
Rafalz13 opened this issue Oct 4, 2024 · 0 comments
Open

CloudForCustomers - remove get_response() method #1081

Rafalz13 opened this issue Oct 4, 2024 · 0 comments
Labels
enhancement New feature or request

Comments

@Rafalz13
Copy link
Contributor

Rafalz13 commented Oct 4, 2024 •
edited by trymzet
Loading

Similar as with other sources, but here the method is called get_response() rather than api_connection(). The to_df() and other methods (extract_records() etc.) should be refactored into pure functions to follow basic programming practices.

comment : #1071 (comment)
@Rafalz13 Rafalz13 added the enhancement New feature or request label Oct 4, 2024
@Rafalz13 Rafalz13 mentioned this issue Oct 4, 2024
Merged
5 tasks
@trymzet trymzet changed the title Check C4C to remove report_url logic CloudForCustomer - remove api_connection() method Oct 4, 2024
@trymzet trymzet changed the title CloudForCustomer - remove api_connection() method CloudForCustomer - remove get_response() method Oct 4, 2024
@trymzet trymzet changed the title CloudForCustomer - remove get_response() method CloudForCustomers - remove get_response() method Oct 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@Rafalz13