Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

modular options docs update #124

Open
SassNinja opened this issue May 8, 2018 · 1 comment
Open

modular options docs update #124

SassNinja opened this issue May 8, 2018 · 1 comment

Comments

@SassNinja
Copy link

It took me a while to realize the option modular: true is not part of the riot compiler but a custom option of this gulp plugin.

Within the plugin additional code gets prepended as

if (options.modular) {
      compiledCode = ...
}

Imo it should be more clear that the modular option isn't an option of the actual riot compiler. The docs shouldn't link to the riot docs when describing it or rather point out it's a custom option.

Would you mind to update the docs?

@e-jigsaw
Copy link
Owner

e-jigsaw commented May 9, 2018

yes, pull requests welcome!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants