Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🔥 Remove the transition notify plugin #925

Merged
merged 3 commits into from
Feb 17, 2023
Merged

🔥 Remove the transition notify plugin #925

merged 3 commits into from
Feb 17, 2023

Commits on Feb 17, 2023

  1. 🔥 Remove the transition notify plugin 

    Per e-mission/e-mission-docs#838 (comment)
This is the first step in which I remove all the controls related to it

```
$ grep -ri notify www/js/control | wc -l
       0
$ grep -ri notify www/templates/control/ | wc -l
       0
```

Testing done:
Profile screen loads correctly
    @shankari
    shankari committed Feb 17, 2023
    Configuration menu
    Copy the full SHA
    8004804 View commit details
    Browse the repository at this point in the history

  2. 🔥 Remove the post-trip-prompt code 

    This includes both copies (incident and survey)

Testing done:
- No instances left

```
$ grep -ri posttrip.prompt www/js
$ grep -ri PostTripAutoPrompt www/js
$
```

- UI loaded without errors
    @shankari
    shankari committed Feb 17, 2023
    Configuration menu
    Copy the full SHA
    c13f663 View commit details
    Browse the repository at this point in the history

  3. 🔥 Remove the plugin from cordova 

    After removing all the uses of the package, remove the package itself
    @shankari
    shankari committed Feb 17, 2023
    Configuration menu
    Copy the full SHA
    834c0d8 View commit details
    Browse the repository at this point in the history