Support additional types of push notifications #840
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Concretely: - "popup": which is a short and simple message that does not have any associated images - "website": which opens the website in a separate In-App-Browser but without the additional complexity from the survey code. Not sure whether website is strictly necessary since survey without any parameters should also work, but adding it may increase usability + sample specs for both kinds of pushes
Since we use it to send: - surveys: which support filling in certain fields with the UUID - notify: which essentially just displays the title and message (not sure if we still need this given the popup support) - popup: displays a short text-only message as a popup - website: launches a separate website in an IAB (not sure if we need this or should we reuse/rename survey instead)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New types are:
Also, rename the
send_surveyscript to reflect the new functionalityNote that we can potentially EOL the existing
notifytype and replace it withpopupWe may not need
websiteand instead usesurveywithout the UUID replacement, but this seems to have better usability.