Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lack of gRPC client integration tests #63

Open
blewater opened this issue May 6, 2021 · 0 comments
Open

Lack of gRPC client integration tests #63

blewater opened this issue May 6, 2021 · 0 comments
Labels
enhancement New feature or request integration
Milestone

Comments

@blewater
Copy link
Contributor

blewater commented May 6, 2021

The Cosmos Stargate SDK upgrade introduced Protobuf serialization and gRPC as the API interface. Even the revamped Rest endpoints are served through the gRPC gateway pipe and lose their simplicity benefits when signing transactions. 
While the code base features Gingko integration tests, these exercise the CLI interface hardly the nominal choice for integrating external applications.

Exceptions

  1. A POC demonstrating legacy transaction signing compatibility with the Ledger device through the CosmJS library.

  2. A gRPC client with minimal API surface for query/response and transaction signing layer for the Bep3 module.

Proposed Solutions

  • Replace a good portion of the existing Gingko tests with the CosmJS library that uses Protobuf and gRPC in its Stargate edition the defacto standard for external application integration work. Moreover, the same tests would function as an on-boarding aid and functional code samples for front-end integration work.

  • Test with an enhanced gRPC Client. An obvious benefit is a tight integration with the existing Go source base and rapid implementation speed. They may also form the basis for a future em-ledger SDK for Golang integrators, though unlikely a popular choice for the envisioned audiences.

@blewater blewater added this to the Stargate milestone May 6, 2021
@blewater blewater added enhancement New feature or request integration labels May 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request integration
Projects
None yet
Development

No branches or pull requests

1 participant