Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: emailer pref is always set to php if you save bulkmailer preferences #5355

Open
Jimmi08 opened this issue Nov 1, 2024 · 1 comment
Labels
type: bug A problem that should not be happening

Comments

@Jimmi08
Copy link
Contributor

Jimmi08 commented Nov 1, 2024

What e107 version are you using?

v2.3.3

Bug description

If you save bulkmailer preferences (f.e. smtp), your emailer preference is always set to PHP.

How to reproduce

  1. Go to Preferences, select Emailer SMTP.
  2. Go to Users/Mail/Preferences, select SMTP and save
  3. Return back to Preferences and your emailer is PHP

Expected behavior

Don't change Emailer settings by saving other preferences

What browser(s) are you seeing the problem on?

Chrome / Brave

PHP Version

8.2

@Jimmi08 Jimmi08 added the type: bug A problem that should not be happening label Nov 1, 2024
@Jimmi08
Copy link
Contributor Author

Jimmi08 commented Nov 1, 2024

It is the long time issue, I noticed this behavior in 2020: #4123

The reason for this bug is this code in mailout.php
if (!in_array($_POST['mailer'], array('smtp', 'sendmail', 'php'))) $_POST['mailer'] = 'php';
In this file, there is no mailer field if $_POST, only bulkmailer Or it should be a hidden field with this test.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: bug A problem that should not be happening
Projects
None yet
Development

No branches or pull requests

1 participant