From aa302edc96d61774fbccf276523a00da716a7b85 Mon Sep 17 00:00:00 2001 From: Tomas Valenta Date: Mon, 21 Oct 2024 10:35:54 -0700 Subject: [PATCH] Change exception descriptions; Add TODO comment --- packages/js-sdk/src/sandbox/commands/commandHandle.ts | 1 + .../python-sdk/e2b/sandbox_async/commands/command_handle.py | 2 +- packages/python-sdk/e2b/sandbox_sync/commands/command_handle.py | 2 +- 3 files changed, 3 insertions(+), 2 deletions(-) diff --git a/packages/js-sdk/src/sandbox/commands/commandHandle.ts b/packages/js-sdk/src/sandbox/commands/commandHandle.ts index 42d4b3313..93eb957d8 100644 --- a/packages/js-sdk/src/sandbox/commands/commandHandle.ts +++ b/packages/js-sdk/src/sandbox/commands/commandHandle.ts @@ -218,6 +218,7 @@ export class CommandHandle } break } + // TODO: Handle empty events like in python SDK } } diff --git a/packages/python-sdk/e2b/sandbox_async/commands/command_handle.py b/packages/python-sdk/e2b/sandbox_async/commands/command_handle.py index 0523432bc..0b9d2349d 100644 --- a/packages/python-sdk/e2b/sandbox_async/commands/command_handle.py +++ b/packages/python-sdk/e2b/sandbox_async/commands/command_handle.py @@ -172,7 +172,7 @@ async def wait(self) -> CommandResult: raise self._iteration_exception if self._result is None: - raise Exception("Process ended without an end event") + raise Exception("Command ended without an end event") if self._result.exit_code != 0: raise CommandExitException( diff --git a/packages/python-sdk/e2b/sandbox_sync/commands/command_handle.py b/packages/python-sdk/e2b/sandbox_sync/commands/command_handle.py index 5dbf6e0d4..edb18d11d 100644 --- a/packages/python-sdk/e2b/sandbox_sync/commands/command_handle.py +++ b/packages/python-sdk/e2b/sandbox_sync/commands/command_handle.py @@ -124,7 +124,7 @@ def wait( raise self._iteration_exception if self._result is None: - raise Exception("Process ended without an end event") + raise Exception("Command ended without an end event") if self._result.exit_code != 0: raise CommandExitException(