Skip to content
This repository has been archived by the owner on Aug 1, 2019. It is now read-only.

[discussion] adding maintainers to the project #149

Open
dodikk opened this issue Jul 28, 2017 · 6 comments
Open

[discussion] adding maintainers to the project #149

dodikk opened this issue Jul 28, 2017 · 6 comments

Comments

@dodikk
Copy link

dodikk commented Jul 28, 2017

Continue discussion from #140

@atainter do you time in the meanwhile to review PRs and issues?

Thanks,
David Schechter
@suprie @DavidSchechter @dodikk
Hi all,

As much as I would like to contribute to open source, I don't think I can right now because of my other responsibilities. I might have time to jump back in at some point, but I don't know when that will be.

In the meantime, I'll talk to our legal team about adding maintainers to the project.

Aaron
@alexandremorgado @dodikk You both seem pretty active on this project. Would you be interested in becoming contributors?
@dodikk
Copy link
Author

dodikk commented Jul 28, 2017

@alexandremorgado @dodikk You both seem pretty active on this project. Would you be interested in becoming contributors?

@atainter , @DavidSchechter I'm definitely interested to try but I'll definitely need some help

  1. I still might not understand how some parts of the code work
  2. I'm pretty bad at AsyncDisplayKit (Texture) so I'd like my fixes to be reviewed and corrected.
  3. I'm pretty busy at my primary job so I might not be capable of solving the "PRs do not get reviewed" problem alone.

@alexandremorgado
Copy link

Hi guys! I am in the same situation as @dodikk. I like NMessenger very much, I would like to help, but I have that exactly 3 limitations exposed by him.

@suprie
Copy link
Contributor

suprie commented Aug 22, 2017

@dodikk @alexandremorgado

This is what i think:
1, 2. it something that you can learn in time
3. You don't have to do it alone, with growing popular of this library, a lot people will start asking to be a contributor.

@atainter
Copy link
Contributor

Hey guys, just an update. I've been talking to some people in our legal department about adding contributors (sorry, it takes quite a bit of time :/). I think I should have clarity on this by the end of the week.

As far as 1 and 2, I can provide some feedback if you have specific questions, but I do agree with @suprie. It shouldn't take too long to learn this library (it's pretty minimal). We also have quite a few unit/UI tests that should be run before merging into master which can help find potential issues.

@atainter
Copy link
Contributor

atainter commented Sep 6, 2017

Update: I still haven't gotten a response. I'm trying to follow up with some other people about this.

@alexandremorgado
Copy link

I really would like to help as a maintainer, but I can't take this responsibility for now. At the moment, I'm the only iOS dev on my startup, where I have other roles and responsibilities, so I could not have time to learning NMessenger and Texture in deep. Sorry, guys, sorry @atainter.

But I'll try to keep helping participating and eventually submitting PRs.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants