Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Issue 91: Update Page Notice stories to use EbayPageNoticeTitle #118 #121

Merged
merged 1 commit into from
Oct 12, 2022
Merged

Issue 91: Update Page Notice stories to use EbayPageNoticeTitle #118 #121

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
40 changes: 24 additions & 16 deletions src/ebay-page-notice/__tests__/__snapshots__/index.spec.tsx.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,11 +28,13 @@ exports[`Storyshots ebay-page-notice Attention message 1`] = `
<div
class="page-notice__main"
>
<h2
class="page-notice__title"
>
Error.
</h2>
<p>
<strong>
Error.
</strong>
  Please take another look at the following:
Please take another look at the following:
<br />
<a
href="#"
Expand Down Expand Up @@ -86,11 +88,13 @@ exports[`Storyshots ebay-page-notice Confirmation message 1`] = `
<div
class="page-notice__main"
>
<h2
class="page-notice__title"
>
Congrats!
</h2>
<p>
<strong>
Congrats!
</strong>
  You just listed
You just listed
<a
href="#"
>
Expand Down Expand Up @@ -202,11 +206,13 @@ exports[`Storyshots ebay-page-notice Dismissible notice 1`] = `
<div
class="page-notice__main"
>
<h2
class="page-notice__title"
>
Good news!
</h2>
<p>
<strong>
Good news!
</strong>
  You get free shipping on your next pair of shoes!
You get free shipping on your next pair of shoes!
<a
href="#"
>
Expand Down Expand Up @@ -268,11 +274,13 @@ exports[`Storyshots ebay-page-notice Information message 1`] = `
<div
class="page-notice__main"
>
<h2
class="page-notice__title"
>
Good news!
</h2>
<p>
<strong>
Good news!
</strong>
  You get free shipping on your next pair of shoes!
You get free shipping on your next pair of shoes!
<a
href="#"
>
Expand Down
8 changes: 4 additions & 4 deletions src/ebay-page-notice/__tests__/index.stories.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,8 +13,8 @@ storiesOf(`ebay-page-notice`, module)
.add(`Confirmation message`, () => (<>
<EbayPageNotice status="confirmation" aria-label="Success">
<EbayNoticeContent>
<EbayPageNoticeTitle>Congrats!</EbayPageNoticeTitle>
<p>
<strong>Congrats!</strong>&nbsp;
You just listed <a href="#">Spam and Eggs From the Cows Perspective</a> (paperback).
</p>
</EbayNoticeContent>
Expand All @@ -24,8 +24,8 @@ storiesOf(`ebay-page-notice`, module)
.add(`Information message`, () => (<>
<EbayPageNotice status="information" aria-label="Information">
<EbayNoticeContent>
<EbayPageNoticeTitle>Good news!</EbayPageNoticeTitle>
<p>
<strong>Good news!</strong>&nbsp;
You get free shipping on your next pair of shoes! <a href="#">Learn more</a>.
</p>
</EbayNoticeContent>
Expand All @@ -35,8 +35,8 @@ storiesOf(`ebay-page-notice`, module)
.add(`Attention message`, () => (<>
<EbayPageNotice status="attention" aria-label="Attention">
<EbayNoticeContent>
<EbayPageNoticeTitle>Error.</EbayPageNoticeTitle>
<p>
<strong>Error.</strong>&nbsp;
Please take another look at the following:<br />
<a href="#">Card number</a>, <a href="#">Expiration date</a> &amp; <a href="#">Security code</a>.
</p>
Expand All @@ -59,8 +59,8 @@ storiesOf(`ebay-page-notice`, module)
.add(`Dismissible notice`, () => (<>
<EbayPageNotice status="information" aria-label="Information" a11yDismissText="Close">
<EbayNoticeContent>
<EbayPageNoticeTitle>Good news!</EbayPageNoticeTitle>
<p>
<strong>Good news!</strong>&nbsp;
You get free shipping on your next pair of shoes! <a href="#">Learn more</a>.
</p>
</EbayNoticeContent>
Expand Down