fix get peer info of removed member #108
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Codecov ReportAttention: Patch coverage is
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #108 +/- ##
==========================================
+ Coverage 71.47% 72.58% +1.10%
==========================================
Files 21 20 -1
Lines 887 879 -8
Branches 103 101 -2
==========================================
+ Hits 634 638 +4
+ Misses 188 173 -15
- Partials 65 68 +3 ☔ View full report in Codecov by Sentry. 🚨 Try these New Features:
|
xiaoxichen
previously approved these changes
Nov 19, 2024
JacksonYao287
force-pushed
the
fix-get-peer-info-of-removed-member
branch
2 times, most recently
from
18a83e6
to
9d26e39
Compare
JacksonYao287
force-pushed
the
fix-get-peer-info-of-removed-member
branch
from
9d26e39
to
db6dc61
Compare
in nuobject test, a removed member will try to get the info of itself to identify whether it is in a pg. but ATM , it is not in the configuration of this raft group. this PR aims to handle this case.
JacksonYao287
force-pushed
the
fix-get-peer-info-of-removed-member
branch
from
db6dc61
to
c47a0c8
Compare
xiaoxichen
approved these changes
Nov 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
in nuobject test, a removed member will try to get the info of itself to identify whether it is in a pg. but ATM , it is not in the configuration of this raft group. this PR aims to handle this case.